Add iPhone X Support #105
Merged
Add iPhone X Support #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the spacing for iPhone X
Owner
|
Hi @ngandhy Do you know what version react-native |
|
@testshallpass |
Contributor
Author
|
@testshallpass @adcuz is right about 0.50.0. Sorry for the delay, I missed your earlier questions notification. |
testshallpass
approved these changes
Feb 2, 2018
Owner
testshallpass
left a comment
testshallpass
left a comment
There was a problem hiding this comment.
👍 Let's get the snapshot tests updated and we good to go. Also since it needs a later react-native version this will be need to be noted on Readme in news section and a major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the spacing for iPhone X.
When I tested it didn't see any difference on other iPhone models or Android (where that view is a no-op)