Added support for custom user agent#1748
Merged
drwetter merged 2 commits intotestssl:3.1devfrom Oct 17, 2020
definity:3.1dev
Merged
Added support for custom user agent#1748drwetter merged 2 commits intotestssl:3.1devfrom definity:3.1dev
drwetter merged 2 commits intotestssl:3.1devfrom
definity:3.1dev
Conversation
Closed
Collaborator
|
Thank you! |
Collaborator
|
I try to just declare those kind of things once and not every where. :-) If you don't mind you can add the feature to the CHANGES file. And while am at it (asking): below the doc dir are man pages. If you could just add a line there that would be awesome ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First stab at adding support... it seemed a bit too complicated to try and add UA_CUSTOM everywhere and try to then add checks to deal with in all the places where checks for SNEAKY were set or not, so I chose to just update UA_STD instead. I wasn't sure if you were declaring all variables as read-only, but after seeing some where you didn't I figured this would be the easiest way to work in support.
Tested the script running and confirmed I was able to see the user-agent in logging reflect what I put on the command-line.
I'm ready for abuse/flogging/feedback.