Refactor apk usage in Dockerfile
#1799
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As there is `apk upgrade` and `apk update`, the apk index will already be existed. `--no-cache` is for `apk` when there is no `apk update` behavior and it's expected to be no local cache left, not suitable for the use case here, which wants to upgrade all the package to the latest when packaging the image.
This will make the image smaller.
Collaborator
|
Why do you prefer removing the apt-cache instead of not building it? |
Contributor
Author
|
I'm not sure I understand the question. The |
Collaborator
|
sorry, I just looked at the changed lines. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are two changes:
--no-cacheforapkin DockerfileThese will make the build faster and the built image smaller.
The details are in the commit message.