Skip to content

Conversation

@tosticated
Copy link
Contributor

@tosticated tosticated commented Dec 22, 2020

PR to address feature request #1770.

@drwetter
Copy link
Collaborator

Thanks! basically fine but to be honest both the cmd line and the global vars CUSTOMHTTPHEADER(S) got a bit too long for my taste. I'll chew on this during there days.

@tosticated
Copy link
Contributor Author

I agree, the variable is a bit long. Perhaps something like 'reqheader'? Let me know if I need to make any changes.

@drwetter
Copy link
Collaborator

drwetter commented Dec 25, 2020

agree, the variable is a bit long. Perhaps something like 'reqheader'?

as I woke up today I was exactly thinking about that.

Let me know if I need to make any changes.

Yes, please. That would be great. Thanks for the Changelog too.

Then I can stash your branch I checked out.

Cheers, Dirk

@tosticated
Copy link
Contributor Author

Alright, changed it to reqheader everywhere. Should be ok to merge.

@drwetter drwetter merged commit ffe223f into testssl:3.1dev Dec 26, 2020
@drwetter
Copy link
Collaborator

Thank you!

@tosticated tosticated deleted the custom_http_headers branch December 27, 2020 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants