Merged
Conversation
This commit fixes testssl#2198 by ensuring that a comma is added before "service" finding if $FIRST_FINDING is false.
Collaborator
|
Thanks, David. Not sure whether this is needed for 3.0 too? |
dcooper16
added a commit
to dcooper16/testssl.sh
that referenced
this pull request
Aug 25, 2022
This commit is the same as testssl#2211, but for the 3.0 branch.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2198 by ensuring that a comma is added before "service" finding if $FIRST_FINDING is false.