Merged
Conversation
This commit fixes testssl#1747 by converting PEM encoded certificates that are sent to fileout() to a single line. As suggested in testssl#1747, '\n' is added after the '----- BEGIN ... -----' line and before the '------ END ... ------' line. In order to ensure that '\n' appears in the string in the JSON and CSV files, '\\n' is sent to fileout() so that 'printf -- "%b"' converts '\\n' to '\n' rather than converting '\n' to a newline character. In order to prevent fileout() from converting '\\n' to '\ ', this commit move the fix for testssl#2049 (see PR testssl#2050) from fileout() to fatal().
dcooper16
force-pushed
the
pem_fileout
branch
from
b3a49b9 to
3eb8cf6
Compare
Collaborator
|
Thanks, David. The CI run ran for hours. Just restarted it |
dcooper16
pushed a commit
to dcooper16/testssl.sh
that referenced
this pull request
Nov 25, 2022
This commit fixes incorrect indentations introduced in testssl#2276 and testssl#2278, and also removes the extra whitespace that would have been removed by testssl#2279.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1747 by converting PEM encoded certificates that are sent to
fileout()to a single line. As suggested in #1747, '\n' is added after the '----- BEGIN ... -----' line and before the '------ END ... ------' line.In order to ensure that '\n' appears in the string in the JSON and CSV files, '\\n' is sent to
fileout()so thatprintf -- "%b"converts '\\n' to '\n' rather than converting '\n' to a newline character.In order to prevent
fileout()from converting '\\n' to '\ ', this PR moves the fix for #2049 (see PR #2050) fromfileout()tofatal().