Feature Trustcor certificates being removed/disabled from root stores #2293#2311
Merged
drwetter merged 2 commits intotestssl:3.1devfrom Feb 2, 2023
Merged
Feature Trustcor certificates being removed/disabled from root stores #2293#2311drwetter merged 2 commits intotestssl:3.1devfrom
drwetter merged 2 commits intotestssl:3.1devfrom
Conversation
…alue regular expression for Organization name and making it clear that CA's are actively removed from 1+ root stores.
Collaborator
|
Thanks a lot! |
Collaborator
|
Hi @sslbrain , do you mind to submit a PR for 3.0x. too? |
Contributor
Author
|
Sure not a problem, another PR created #2319 for 3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add feature TrustCor Certificate #2293
Change exception for removed root certificates into easy edit multi-value regular expression for Organization name and making it clear that CA's are actively removed from 1+ root stores.
Organization is safer to search on, as it can only contain validated information, if more precise/alternative is needed hash would probably be better but more difficult to maintain.
Other CA's of interest all seem to have no more active certificates i.e. WoSign, DigiNotar, etc. so only TrustCor seems currently relevant.
An active certificate for testing can currently be found here: https://www.trustcor.ca