Add support for brainpool curves with TLS 1.3#2353
Merged
drwetter merged 1 commit intotestssl:3.1devfrom Mar 31, 2023
Merged
Conversation
This commit adds support for the curves brainpoolP256r1tls13, brainpoolP384r1tls13, and brainpoolP512r1tls13.
Collaborator
|
Thanks a lot, David! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the curves brainpoolP256r1tls13, brainpoolP384r1tls13, and brainpoolP512r1tls13.
Based on #2346, I included the "tls13" in the names that used, even though brainpoolP256r1 and brainpoolP256r1tls13 are both the same curve, just for use with different TLS versions. This is the reason for lines 10743 - 10745. OpenSSL reports the curve as just brainpoolP...r1, even if it is the brainpoolP...r1tls13 code point, so I need to look at which version of TLS was negotiated to determine which code point was used.
I was not able to test utils/update_client_sim_data.pl, but the change that I made to it seems straightforward.