Secure renegotiations tests need servername for servers that use SNI#2360
Merged
drwetter merged 6 commits intotestssl:3.1devfrom May 15, 2023
mum-viadee:run_renego_sni_patch
Merged
Secure renegotiations tests need servername for servers that use SNI#2360drwetter merged 6 commits intotestssl:3.1devfrom mum-viadee:run_renego_sni_patch
drwetter merged 6 commits intotestssl:3.1devfrom
mum-viadee:run_renego_sni_patch
Conversation
Collaborator
|
Hi, okay & thanks. A server with noservername.... I'll wait until the CI run passes. Cheers, Dirk |
clarify comment
Collaborator
|
I don't know what actually happened. Maybe there was a prob in front of the keyboard. I wanted to change the comment into "In cases where there's no default host configured we need SNI here as otherwise openssl then would return an error and the test will fail" Could you clean that up ? Sorry! |
This reverts commit e33e0bc.
Contributor
Author
|
Hi @drwetter, Your commit was reverted and the comment was added again. Greeting |
Collaborator
|
Thanks, @mum-viadee ! Also in my case it was the online editor. :-/ |
Tazmaniac
added a commit
to Tazmaniac/testssl.sh
that referenced
this pull request
Sep 8, 2023
Not exactly for the same reason, but we need SNI too for secure renego tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Secure renegotiations tests need servername for servers that use SNI. Otherwise openssl fails with return code 1.
See #2359