Skip to content

Fix: Reporting (Not Ok) for ClientHello/ServerHello errors#2544

Merged
drwetter merged 1 commit intotestssl:3.2from
NaN-KL:patch-1
Aug 26, 2024
Merged

Fix: Reporting (Not Ok) for ClientHello/ServerHello errors#2544
drwetter merged 1 commit intotestssl:3.2from
NaN-KL:patch-1

Conversation

@NaN-KL
Copy link
Copy Markdown
Contributor

@NaN-KL NaN-KL commented Aug 23, 2024

This is a fix to be consistent in reporting (Not Ok) for ClientHello/ServerHello errors.

An example of the issue can be observed here:
https://i.imgur.com/JFpN03q.png

While the TLS1 line is orange and red there is no (Not OK) indicator. This PR seeks to bring consistency in reporting this issue.

What is your pull request about?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs and the indentation is five spaces
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

Fix to be consistent in reporting (Not Ok) for ClientHello/ServerHello errors.
@drwetter drwetter merged commit b132a26 into testssl:3.2 Aug 26, 2024
@drwetter
Copy link
Copy Markdown
Collaborator

ok, thanks. Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants