Fix: Reporting (Not Ok) for ClientHello/ServerHello errors#2544
Merged
drwetter merged 1 commit intotestssl:3.2from Aug 26, 2024
Merged
Fix: Reporting (Not Ok) for ClientHello/ServerHello errors#2544drwetter merged 1 commit intotestssl:3.2from
drwetter merged 1 commit intotestssl:3.2from
Conversation
Fix to be consistent in reporting (Not Ok) for ClientHello/ServerHello errors.
Collaborator
|
ok, thanks. Makes sense! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to be consistent in reporting (Not Ok) for ClientHello/ServerHello errors.
An example of the issue can be observed here:
https://i.imgur.com/JFpN03q.png
While the TLS1 line is orange and red there is no (Not OK) indicator. This PR seeks to bring consistency in reporting this issue.
What is your pull request about?
If it's a code change please check the boxes which are applicable
help()