Skip to content

Conversation

@dcooper16
Copy link
Collaborator

Describe your changes

This PR modifies testssl.sh so that TLS 1.3 handshakes that use post-quantum algorithms for key exchange can be decrypted, if $OPENSSL supports the algorithms.

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

@drwetter
Copy link
Collaborator

Hi David,

first: awesome !

Looking forward if someone reads the code and like to understand what it does, it would be cool if there would be some comments explaining that better.

@drwetter
Copy link
Collaborator

Also, as it's worth to mention: Amending the CHANGELOG.md / Credits.md would be appropriate

@dcooper16 dcooper16 force-pushed the tls13_pq_kx branch 4 times, most recently from a0e5b59 to 3a26b27 Compare April 10, 2025 17:13
@dcooper16
Copy link
Collaborator Author

I added some more comments, but I don't think anything more needs to be added to CHANGELOG.md orCredits.md. They already mention support for the PQC key exchange groups and for decrypting TLS 1.3 traffic.

This commit modifies testssl.sh so that TLS 1.3 handshakes that use post-quantum algorithms for key exchange can be decrypted, if $OPENSSL supports the algorithms.
@drwetter drwetter merged commit a701541 into testssl:3.2 Apr 11, 2025
2 checks passed
@drwetter
Copy link
Collaborator

Super!

@dcooper16 dcooper16 deleted the tls13_pq_kx branch April 11, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants