Conversation
|
After this PR, I think the two variants should be fairly straight-forward maintenance wise, thanks for your patience 😅 With the two links added to The last item to resolve #2422 is updating the workflow to default to openSUSE Leap to be consistent with DockerHub and prefer the glibc base image. But until migrating away from openSUSE Leap, you'd have the reduced architecture support. Hence it'd be better to have DockerHub + GHCR publishing both image variants, but I'm not yet familiar with the GHA caching approach so I will need to defer that task until I have time to grok that better. The original PR that contributed the workflow lacks context and I prefer to understand the decision well before changing it. |
|
Thanks for your work @polarathene !
I would just leave it like it is, for now. Don´t even know how about the usage of those containers for sure. The only thing I was able to retrieve was this: https://github.com/testssl/testssl.sh/packages |
Perhaps for 3.3 then. Alpine variants are typically tagged with a prefix |
Describe your changes
Dockerfilevariants, with revised inline docs.Dockerfileadopts HereDoc syntax for better formatting inRUN.Dockerfile.mddocs revised with:NOTE: I could revert the Alpine change for
addgroup/adduser, but figured maintenance is easier if you don't have to think aboutuseraddvsadduserdifferences.Dockerfilewith only two lines for Alpine support (and selected via a--build-argor--targetstage), makingDockerfile.alpineredundant. SeparateDockerfileis absolutely fine though 👍Adopting the HereDoc feature was originally proposed in Feb 2023 but rejected due to being considered too new. It's been over 2 years since then and anyone building images today should really be using Docker v23 (Feb 2023) at a minimum.
HereDoc removes the
&& \noise withRUN, the value is treated as a multi-line string that/bin/sh -creceives (symlinked tobashby openSUSE Leap, or toashby Alpine_), thus it's more like a typical inline shell script.What is your pull request about?