Skip to content

Removed rogue space on QUIC output#2828

Merged
drwetter merged 2 commits intotestssl:3.3devfrom
digininja:3.3dev
Jul 8, 2025
Merged

Removed rogue space on QUIC output#2828
drwetter merged 2 commits intotestssl:3.3devfrom
digininja:3.3dev

Conversation

@digininja
Copy link
Contributor

There was an extra space in the output when QUIC wasn't offered or timed out, this has removed it for that specific instance.

Before:

 TLS 1.2    offered (OK)
 TLS 1.3    not offered and downgraded to a weaker protocol
 QUIC        not offered or timed out
 NPN/SPDY   not offered

After:

 TLS 1.2    offered (OK)
 TLS 1.3    not offered and downgraded to a weaker protocol
 QUIC       not offered or timed out
 NPN/SPDY   not offered

Describe your changes

There is an extra space after QUIC in the --protocols output.

What is your pull request about?

  • [] Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • [ x] Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • [ x] For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • [ x] I've read CONTRIBUTING.md and Coding_Convention.md
  • [ x] I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

Before:

```
 TLS 1.2    offered (OK)
 TLS 1.3    offered (OK): final
 QUIC        not offered or timed out
 NPN/SPDY   not offered                                                                                      
 ALPN/HTTP2 h2, http/1.1 (offered)                                                                           
```

After:

```
 TLS 1.2    offered (OK)
 TLS 1.3    offered (OK): final
 QUIC       not offered or timed out
 NPN/SPDY   not offered
 ALPN/HTTP2 h2, http/1.1 (offered)
```
@drwetter
Copy link
Collaborator

drwetter commented Jul 8, 2025

Thanks, @digininja . You're right. Please see comment though

@digininja
Copy link
Contributor Author

Which comment?

@drwetter
Copy link
Collaborator

drwetter commented Jul 8, 2025

The re-added one for which I didn't forget to hit the "submit" button 🤓

@digininja
Copy link
Contributor Author

digininja commented Jul 8, 2025 via email

@drwetter
Copy link
Collaborator

drwetter commented Jul 8, 2025

The domain is basically every domain which supports QUIC (google.com, cloudflare.com, testssl.net, ...) . But you have to specify a proxy on the cmdline and the other condition is that UDP egress is not allowed.

I am pretty sure it works. ;-)

@digininja
Copy link
Contributor Author

done, extra space added

@drwetter drwetter merged commit 2fd80e7 into testssl:3.3dev Jul 8, 2025
3 checks passed
@drwetter
Copy link
Collaborator

drwetter commented Jul 8, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants