Removed rogue space on QUIC output#2828
Merged
drwetter merged 2 commits intotestssl:3.3devfrom Jul 8, 2025
Merged
Conversation
Before: ``` TLS 1.2 offered (OK) TLS 1.3 offered (OK): final QUIC not offered or timed out NPN/SPDY not offered ALPN/HTTP2 h2, http/1.1 (offered) ``` After: ``` TLS 1.2 offered (OK) TLS 1.3 offered (OK): final QUIC not offered or timed out NPN/SPDY not offered ALPN/HTTP2 h2, http/1.1 (offered) ```
Collaborator
|
Thanks, @digininja . You're right. Please see comment though |
Contributor
Author
|
Which comment? |
drwetter
reviewed
Jul 8, 2025
Collaborator
|
The re-added one for which I didn't forget to hit the "submit" button 🤓 |
Contributor
Author
|
I can add that, do you have a domain I can test it with, just to make sure.
…On Tue, 8 Jul 2025, 16:30 Dirk Wetter, ***@***.***> wrote:
*drwetter* left a comment (testssl/testssl.sh#2828)
<#2828 (comment)>
The re-added one for which I didn't forget to hit the "submit" button 🤓
—
Reply to this email directly, view it on GitHub
<#2828 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4SWIZMTGKM5RULMQFC4D3HPPYTAVCNFSM6AAAAACBAJ6PS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBZGQYTENBTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
The domain is basically every domain which supports QUIC (google.com, cloudflare.com, testssl.net, ...) . But you have to specify a proxy on the cmdline and the other condition is that UDP egress is not allowed. I am pretty sure it works. ;-) |
Contributor
Author
|
done, extra space added |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an extra space in the output when QUIC wasn't offered or timed out, this has removed it for that specific instance.
Before:
After:
Describe your changes
There is an extra space after QUIC in the
--protocolsoutput.What is your pull request about?
If it's a code change please check the boxes which are applicable
help()