Flag absence of extended master secret extension#2982
Merged
Conversation
This PR fixes #2806 and implements a feature request. TLS >=1.2 MUST support support the extended_master_secret extension to address an attack resulting from TLS session parameters not being properly authenticated in a Triple Handshake scanario (https://ieeexplore.ieee.org/document/6956559). Only if the extension is missing there will be a medium severity level finding. JSON output will be generated in any case. Also in determine_tls_extensions() some documenation about tls extensions to be send were added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2806 and implements a feature request. TLS >=1.2 MUST support support the extended_master_secret extension to address an attack resulting from TLS session parameters not being properly authenticated in a Triple Handshake scenario (https://ieeexplore.ieee.org/document/6956559).
Only if the extension is missing there will be a medium severity level finding. JSON output will be generated in any case.
Also in
determine_tls_extensions()some documentation about TLS extensions to be send were added.What is your pull request about?
If it's a code change please check the boxes which are applicable
and >=2 host which does not (in order to avoid side effects). I couldn't spot a problemhelp()