Merged
Conversation
This seems like a better abstraction, especially that some of them actually not render anything but approve/validate the results. This seems like a better abstraction not imposing any particular way the result should be handled
and into ConventionContext
They should be in control of how they want the data formatted. We still need to work on how to actually put the two together...
ConventionResult now holds formatted result and recommended file extension. This will save us from having to have a copy of text renderer in almost any other renderer. Also this gives us flexibility to either use existing result, or overwrite it (or ignore and render your own, but not save it back for validation, like HTML renderer does
Member
There was a problem hiding this comment.
We have lost the reporting of the second convention failing?
Contributor
Author
There was a problem hiding this comment.
nope. It's split into a second file now.
Member
|
Im happy to merge, the other stuff can be fixed in another PR |
Contributor
Author
There was a problem hiding this comment.
This is the second file :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm (almost) happy with this one. There's still some work to be done around formatters, but I'm quite happy with how the rest of that turned out.
IMO it's much neater and more flexible than the first few attempts we've had.