Fix verbatim prefix handling in junction creation#31
Merged
tesuji merged 2 commits intotesuji:mainfrom Jan 17, 2026
Merged
Conversation
Junction creation now correctly handles paths with Windows verbatim prefix (\\?\). The prefix is stripped before constructing the reparse point data, preventing double-prefix corruption.
This was referenced Dec 15, 2025
Closed
tesuji
requested changes
Jan 5, 2026
tesuji
reviewed
Jan 5, 2026
tesuji
approved these changes
Jan 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix verbatim prefix handling in junction creation
Summary
This PR fixes #30 where
junction::create()silently fails when called with paths containing the Windows verbatim prefix (\\?\).Problem
When paths from
std::fs::canonicalize()are passed tojunction::create(), the function returnsOk(())but creates a broken junction that cannot be accessed. This is because:get_full_path()returns the path with the verbatim prefix intactcreate()then prepends the NT prefix\??\unconditionally\??\\\?\C:\...Solution
Strip the Win32 verbatim prefix (
\\?\) from the target path before constructing the reparse point data. This is done increate()right after callingget_full_path(), which is the correct location since:get_target()which strips the\??\prefix when readingstrip_prefix().unwrap_or()so paths without the prefix are unchangedTesting
create_with_verbatim_prefix_pathsthat usesfs::canonicalize()to obtain verbatim paths