CI: Ratchet down permissions, hash-pin actions#35
Merged
tesuji merged 1 commit intotesuji:mainfrom Apr 8, 2026
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
tesuji
approved these changes
Apr 8, 2026
Owner
tesuji
left a comment
There was a problem hiding this comment.
lgtm. Will merge when CI green.
Contributor
Author
|
Thanks @tesuji! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there! Thanks for maintaining
junction.As part of my periodic review of the crates that we rely on for uv, I've gone and ahead and proposed (via this PR) some defense-in-depth enhancements to your GitHub Actions setup. These aren't critical, but they reduce the number of permissions available to the workflow and make it more hermetic/reproducible.
Key changes:
permissions: {}at the top-level, which all jobs will inherit. This shouldn't cause any breakage, as none of your current CI jobs need extra permissions. When they do, you can always widen at the per-job level.persist-credentials: falseon everyactions/checkoutusage, to disable GitHub's default behavior of persisting your GITHUB_TOKEN onto disk.pinact run -v. However, I haven't updated them; I recommend using Dependabot or Renovate to auto-update actions (with an appropriate cooldown).Please let me know if there's anything else I can do, including answer other questions about what I've done 🙂