Don't perform an existence check in get_target#36
Merged
Conversation
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
force-pushed
the
ww/rm-exists-check
branch
from
131681e to
92c7864
Compare
Signed-off-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP, leaving in draft until I confirm the CI passes 🙂This removes the destination existence check from
get_target. In other words,get_targetstill validates that the junction itself exists, but not that the junction's destination directory exists. This is consistent with what other languages' junction APIs do, per discussion in #34. It is however a breaking change, so a major version is in order.Closes #34.