Skip to content

QVAC-18794 test: skip multi-gpu tests on mobile#1998

Merged
Victor-Rodzko merged 2 commits into
mainfrom
test/skip-multi-gpu-android
May 12, 2026
Merged

QVAC-18794 test: skip multi-gpu tests on mobile#1998
Victor-Rodzko merged 2 commits into
mainfrom
test/skip-multi-gpu-android

Conversation

@Victor-Rodzko
Copy link
Copy Markdown
Contributor

@Victor-Rodzko Victor-Rodzko commented May 12, 2026

🎯 What problem does this PR solve?

  • multi-gpu-config-smoke reliably crashes the Android consumer in the full SDK smoke suite (native SIGABRT inside libqvac__llm-llamacpp.so), red-blocking CI on every smoke run.
  • Multi-GPU is not a supported deployment target on mobile (single-GPU devices). Per Gianfranco's call in the QVAC-18794 thread, the cleanest fix is to remove multi-gpu-* from the mobile test surface entirely rather than keep an Android-only skip.
  • The crash itself is on the addon side (Adreno OpenCL backend state pollution from prior LLM inference) and is tracked separately in QVAC-18794.

📝 How does it solve it?

  • Add SkipExecutor(/^multi-gpu-/, ...) to the mobile-wide skip block in packages/sdk/tests-qvac/tests/mobile/consumer.ts (alongside finetune-, tools-, etc.), covering both Android and iOS.
  • Remove the MultiGpuExecutor import and handler from the mobile consumer (now dead code on mobile).
  • Desktop multi-gpu coverage is unaffected.

🧪 How was it tested?

With the skip applied — full smoke on all platforms green:

Diagnostics — three Android runs on the same SHA family, same llm-llamacpp@0.18.0 prebuild, same tensor-split: "1,1" config; only the preceding test set differs:

Local: bun run lint (eslint + typecheck) clean in packages/sdk.

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

QVAC E2E — ios — ✅ all tests passed (76/91, 1875s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

QVAC E2E — windows — ✅ all tests passed (91/91, 473s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

QVAC E2E — linux — ✅ all tests passed (91/91, 407s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

QVAC E2E — macos — ✅ all tests passed (91/91, 330s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

QVAC E2E — android — ✅ all tests passed (83/91, 2761s)

Config: suite=smoke · filter=(none) · exclude=(none)
View run · Artifacts: reports · Device Farm logs

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@github-actions github-actions Bot added the e2e-tested Test suite has run on this PR. Does not indicate tests pass/fail - see results in comments. label May 12, 2026
@kinsta
Copy link
Copy Markdown

kinsta Bot commented May 12, 2026

Preview deployments for qvac-docs-staging ⚡️

Status Branch preview Commit preview
🔁 Deploying... N/A N/A

Commit: 14f335423a19dc6c99c6e2ae80745ab34d91c022

Deployment ID: 041cc264-29ab-47bd-a4b2-0c1c2e077082

Static site name: qvac-docs-staging-fazwv

@Victor-Rodzko Victor-Rodzko merged commit 286f8f5 into main May 12, 2026
23 checks passed
@Victor-Rodzko Victor-Rodzko deleted the test/skip-multi-gpu-android branch May 12, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e-tested Test suite has run on this PR. Does not indicate tests pass/fail - see results in comments. test-e2e-smoke Triggers smoke e2e test suite [Currently SDK-only] tier1 verify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants