QVAC-18794 test: skip multi-gpu tests on mobile#1998
Merged
Conversation
bf645d6 to
b6ba60c
Compare
b6ba60c to
c8a5433
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
c8a5433 to
e84e085
Compare
QVAC E2E —
|
QVAC E2E —
|
opaninakuffo
approved these changes
May 12, 2026
Tier-based Approval Status |
NamelsKing
approved these changes
May 12, 2026
Preview deployments for qvac-docs-staging ⚡️
Commit: Deployment ID: Static site name: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
multi-gpu-config-smokereliably crashes the Android consumer in the full SDK smoke suite (native SIGABRT insidelibqvac__llm-llamacpp.so), red-blocking CI on every smoke run.multi-gpu-*from the mobile test surface entirely rather than keep an Android-only skip.📝 How does it solve it?
SkipExecutor(/^multi-gpu-/, ...)to the mobile-wide skip block inpackages/sdk/tests-qvac/tests/mobile/consumer.ts(alongsidefinetune-,tools-, etc.), covering both Android and iOS.MultiGpuExecutorimport and handler from the mobile consumer (now dead code on mobile).🧪 How was it tested?
With the skip applied — full smoke on all platforms green:
Diagnostics — three Android runs on the same SHA family, same
llm-llamacpp@0.18.0prebuild, sametensor-split: "1,1"config; only the preceding test set differs:multi-gpu-config-smokecrashes the consumer ~5 s after start (SIGABRT viaggml_abortinggml_backend_sched_new); tombstone in artifactdevice-farm-logs-android-android-98275cd-75343917571.multi-gpu-*only: https://github.com/tetherto/qvac/actions/runs/25676619728 — both pass (3993 ms / 32916 ms).model,multi-gpufilter (13model-*tests + 2multi-gpu-*): https://github.com/tetherto/qvac/actions/runs/25717007197 — all 15 pass.Local:
bun run lint(eslint + typecheck) clean inpackages/sdk.