feat: add bitwise operations AND, OR, XOR, NOT, LSHIFT, RSHIFT#13
Merged
tetsuo-cpp merged 1 commit intocanonfrom Feb 15, 2026
Merged
feat: add bitwise operations AND, OR, XOR, NOT, LSHIFT, RSHIFT#13tetsuo-cpp merged 1 commit intocanonfrom
tetsuo-cpp merged 1 commit intocanonfrom
Conversation
Owner
Author
Code ReviewOverviewAdds 6 bitwise operations (AND, OR, XOR, NOT, LSHIFT, RSHIFT) across the full compiler stack: dialect definition, parser, MemRef conversion, and tests. Correctness
Style & Conventions
Test Coverage
No Issues FoundClean PR. The implementation is minimal and mechanical — 5 of 6 ops are one-line type aliases, the 6th ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinaryArithOpConversion; NOT uses a unary XOR-with-(-1) patternarith::ShRUIOp(logical/unsigned shift)Closes #3
Test plan
test/Translation/Forth/bitwise-ops.forthtest/Conversion/ForthToMemRef/bitwise.mlircmake --build build --target check-warpforth)