Skip to content

fix search dialog paste handling #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025
Merged

fix search dialog paste handling #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/nreact/src/components/search-dialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import React from 'react'

import throttle from 'lodash.throttle'
import { getBlockParentPage, getBlockTitle } from '@texonom/nutils'

import { NotionContextConsumer, NotionContextProvider } from '../context'
Expand All @@ -12,6 +10,15 @@ import { PageTitle } from './page-title'
import type { SearchParams, SearchResults, APIError } from '@texonom/ntypes'
// TODO: modal.default.setAppElement('.notion-viewport')

// simple debounce utility so we only search after the user stops typing
const debounce = (func: (...args: any[]) => void, wait: number) => {
let timeout: ReturnType<typeof setTimeout> | undefined
return (...args: any[]) => {
if (timeout) clearTimeout(timeout)
timeout = setTimeout(() => func(...args), wait)
}
}

export class SearchDialog extends React.Component<{
isOpen: boolean
rootBlockId: string
Expand All @@ -34,7 +41,8 @@ export class SearchDialog extends React.Component<{
_search: any

componentDidMount() {
this._search = throttle(this._searchImpl.bind(this), 1000)
// debounce search calls so the expensive query only runs after typing stops
this._search = debounce(this._searchImpl.bind(this), 500)
this._warmupSearch()
}

Expand Down Expand Up @@ -66,7 +74,7 @@ export class SearchDialog extends React.Component<{
placeholder='Search'
value={query}
ref={this._inputRef}
onChange={this._onChangeQuery}
onInput={this._onChangeQuery}
/>

{query && (
Expand Down