Skip to content

go-threads v1.0.2#433

Merged
sanderpick merged 3 commits intomasterfrom
sander/threads-v1.0.2
Dec 2, 2020
Merged

go-threads v1.0.2#433
sanderpick merged 3 commits intomasterfrom
sander/threads-v1.0.2

Conversation

@sanderpick
Copy link
Contributor

@sanderpick sanderpick commented Dec 1, 2020

  • Updates go-threads to v1.0.2
  • Since we're using real Stripe keys for staging and production, events from either env are received by both. This doesn't hurt anything, but it does mean that the webhook thinks it's unhealthy and is threatening to delete it. So, if the event fails our biz logic, we just log a warning and return 200. I'd like to create a different stripe account for staging so we can use different live keys there. Then we can revert this change.

@sanderpick sanderpick requested a review from jsign December 1, 2020 17:35
@sanderpick sanderpick force-pushed the sander/threads-v1.0.2 branch from 7500afc to 6d5eb00 Compare December 1, 2020 17:37
@sanderpick
mod: bump go-threads v1.0.2
0a7f5f5 
Signed-off-by: Sander Pick <sanderpick@gmail.com>
@sanderpick
billing: return 200 from webhooks
bbc7ad9 
Signed-off-by: Sander Pick <sanderpick@gmail.com>
@sanderpick
docker: update docker-compose files
5e43762 
Signed-off-by: Sander Pick <sanderpick@gmail.com>
@sanderpick sanderpick force-pushed the sander/threads-v1.0.2 branch from 5bf16c7 to 5e43762 Compare December 1, 2020 22:32
carsonfarmer
carsonfarmer approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@carsonfarmer carsonfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sanderpick sanderpick merged commit f1e5640 into master Dec 2, 2020
@sanderpick sanderpick deleted the sander/threads-v1.0.2 branch December 2, 2020 01:01
andrewxhill pushed a commit that referenced this pull request Dec 3, 2020
@sanderpick @andrewxhill
go-threads v1.0.2 (#433)
49cb12e 
* mod: bump go-threads v1.0.2

Signed-off-by: Sander Pick <sanderpick@gmail.com>

* billing: return 200 from webhooks

Signed-off-by: Sander Pick <sanderpick@gmail.com>

* docker: update docker-compose files

Signed-off-by: Sander Pick <sanderpick@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carsonfarmer carsonfarmer carsonfarmer approved these changes

@jsign jsign Awaiting requested review from jsign

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sanderpick @carsonfarmer