Skip to content

Commit 9f537bd

Browse files
author
Eszter
authored
fix(PillDropdown): add z-index so that it always appears on top (#184)
1 parent 55167ca commit 9f537bd

4 files changed

Lines changed: 22 additions & 15 deletions

File tree

src/components/Pill/PillDropdown/PillDropdown.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ const PillDropdown = React.forwardRef((props, ref) => {
1818
};
1919

2020
return (
21-
<div ref={ref} role="presentation">
22-
<div role="dialog" {...rest} {...block(props)}>
21+
<div ref={ref} role="presentation" {...rest} {...block(props)}>
22+
<div role="dialog" {...elem('dialog', props)}>
2323
<div {...elem('content', props)}>{children({ close })}</div>
2424
<div {...elem('footer', props)}>
2525
<Button context="primary" size="small" onClick={handleDoneClick}>

src/components/Pill/PillDropdown/PillDropdown.scss

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,18 @@
1414
}
1515

1616
.PillDropdown {
17-
background: var(--color-background);
18-
margin: var(--spacing-2x) 0;
19-
border-radius: var(--border-radius);
20-
border: 1px solid var(--color-neutral);
21-
box-shadow: 0 5px 10px rgba(0, 0, 0, 0.1);
22-
transform-origin: top left;
23-
animation: dropdownAppear var(--transition-duration-quick) forwards;
24-
animation-timing-function: linear;
17+
z-index: 500;
18+
19+
&__dialog {
20+
background: var(--color-background);
21+
margin: var(--spacing-2x) 0;
22+
border-radius: var(--border-radius);
23+
border: 1px solid var(--color-neutral);
24+
box-shadow: 0 5px 10px rgba(0, 0, 0, 0.1);
25+
transform-origin: top left;
26+
animation: dropdownAppear var(--transition-duration-quick) forwards;
27+
animation-timing-function: linear;
28+
}
2529

2630
&__content {
2731
padding: var(--pill-dropdown-padding);

src/components/Pill/PillDropdown/__tests__/__snapshots__/PillDropdown.spec.js.snap

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,11 @@ exports[`<PillDropdown> component should render correctly 1`] = `
77
noPadding={false}
88
>
99
<div
10+
className="PillDropdown"
1011
role="presentation"
1112
>
1213
<div
13-
className="PillDropdown"
14+
className="PillDropdown__dialog"
1415
role="dialog"
1516
>
1617
<div

src/components/Pill/__tests__/__snapshots__/Pill.spec.js.snap

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,12 @@ exports[`<Pill> component should open dropdown when button is clicked 1`] = `
5959
popupRef={
6060
Object {
6161
"current": <div
62+
class="PillDropdown"
63+
data-popup="true"
6264
role="presentation"
6365
>
6466
<div
65-
class="PillDropdown"
66-
data-popup="true"
67+
class="PillDropdown__dialog"
6768
role="dialog"
6869
>
6970
<div
@@ -160,11 +161,12 @@ exports[`<Pill> component should open dropdown when button is clicked 1`] = `
160161
noPadding={false}
161162
>
162163
<div
164+
className="PillDropdown"
165+
data-popup="true"
163166
role="presentation"
164167
>
165168
<div
166-
className="PillDropdown"
167-
data-popup="true"
169+
className="PillDropdown__dialog"
168170
role="dialog"
169171
>
170172
<div

0 commit comments

Comments
 (0)