refactor(Tag): migrate Tag component - #1302
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eszthoff
suggested changes
Oct 30, 2024
Contributor
|
I found a bug that possibly was there already. If you use keyboard navigation, you cannot TAB beyond the delete button. The focus is stuck there. I think it is because of the |
eszthoff
approved these changes
Nov 6, 2024
BREAKING CHANGE: 'size' is no longer a prop
Contributor
|
LGTM but please add BREAKING CHANGES to the description and make sure it is copied to the squashed commit when merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONEUI-454
Checklist
BREAKING CHANGE: Tag component's
sizeprop is removed