Skip to content

fix: add teaser breaking change to changelog version 27.0.0 - #1332

Merged
andrentk merged 2 commits into
masterfrom
fix-changelog-breaking-change-teaser
Nov 22, 2024
Merged

fix: add teaser breaking change to changelog version 27.0.0#1332
andrentk merged 2 commits into
masterfrom
fix-changelog-breaking-change-teaser

Conversation

@andrentk

Copy link
Copy Markdown
Contributor

ONEUI-517

Checklist

  • The Pull Request title follows our guidelines eg. feat(PrioritySelector): new component
  • Breaking changes are mentioned eg. BREAKING CHANGE: isMultiSelect prop is removed, if any.
  • Squash and Merge option is selected as merge option.

@vercel

vercel Bot commented Nov 21, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oneui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 10:31am

Comment thread CHANGELOG.md

* **Tag:** 'size' is no longer a prop
* **Dropdown:** Dropdown component API and structure changed
* **Teaser:** Teaser component API and structure changed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha. I was hoping for something more practical :) But fair enough. It was pretty hard to figure out what to put where, but it is the same when looking at Storybook or even Figma. So I think it is just hard to know...

@andrentk andrentk Nov 22, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is more generic now because before if I am not mistaken there was location for example, but now it can be a totally different thing.

@andrentk
andrentk merged commit 18ac712 into master Nov 22, 2024
@andrentk
andrentk deleted the fix-changelog-breaking-change-teaser branch November 22, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants