build: bundle size improvements - #203
Merged
Merged
Conversation
|
|
||
| An implementation example can be found in the example directory, along with instructions on how to run it. | ||
|
|
||
| ## Testing |
Contributor
There was a problem hiding this comment.
Is this no longer relevant? I can't see how OneUI tests are to be ran (apart from testing the application that implements OneUI)
Contributor
Author
There was a problem hiding this comment.
This section is not relevant for README but for CONTRIBUTE. However just to list the scripts that are in package.json is quite redundant. If you think it has actual value, I can put it in CONTRIBUTE.md#Testing
Contributor
There was a problem hiding this comment.
Ok agree, if you want you can still add it to the paragraph you mention.
mukiienko
approved these changes
Dec 20, 2019
| }; | ||
| ``` | ||
|
|
||
| The above RegEx will tell jest to exclude all node_modules (default behavior) but the ones listed in the array above. |
Contributor
There was a problem hiding this comment.
Could you please write jest =-> Jest
| ].join('|'); | ||
|
|
||
| const config = { | ||
| transformIgnorePatterns: [`[\\\/]node_modules[\\\/](?!(${librariesToRecompile})).*$`], |
Contributor
There was a problem hiding this comment.
Did you check this expression? For me, it looks weird
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Story: ONEUI-75