Skip to content

feat(ComboboxMulti): Add new component - #226

Merged
igorarkhipenko merged 26 commits into
masterfrom
108-combobox
Feb 13, 2020
Merged

feat(ComboboxMulti): Add new component#226
igorarkhipenko merged 26 commits into
masterfrom
108-combobox

Conversation

@igorarkhipenko

Copy link
Copy Markdown
Contributor

No description provided.

@igorarkhipenko igorarkhipenko changed the title WIP: feat(Combobox): Add new component feat(Combobox): Add new component Jan 30, 2020
Comment thread src/components/Select/ComboboxMulti/ComboboxMulti.tsx
Comment thread src/components/Select/ComboboxMulti/ComboboxMulti.tsx
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js Outdated
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js Outdated
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js Outdated
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js Outdated
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js Outdated
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js
Comment thread src/components/Select/ComboboxMulti/__tests__/ComboboxMulti.spec.js Outdated
Comment thread src/components/Select/SelectBase/SelectBase.tsx Outdated
Comment thread stories/Combobox.tsx Outdated
...elem('input', { ...props }),
})}
/>
<div {...elem('buttons', { ...props })}>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class (.ComboboxMulti__buttons) doesn't seem to have a definition in the component stylesheet, so it only renders a simple div that has no styles. Is it necessary?

Comment thread src/components/Select/SelectBase/SelectBase.tsx Outdated
Comment thread src/components/Select/SelectBase/SelectBase.tsx Outdated
Comment thread src/components/Select/SelectBase/__tests__/SelectBase.spec.js Outdated
Comment thread src/components/Select/SelectBase/__tests__/SelectBase.spec.js Outdated
Comment thread src/components/Select/SelectBase/__tests__/SelectBase.spec.js Outdated
Comment thread src/components/Select/SuggestionsList/SuggestionsList.tsx
Comment thread src/index.ts
Comment thread stories/Combobox.tsx Outdated
Comment thread stories/Combobox.tsx Outdated
Comment thread stories/Combobox.tsx Outdated
Comment thread src/components/Select/SelectBase/interfaces.ts Outdated
Comment thread src/components/Select/SuggestionsList/__tests__/SuggestionsList.spec.js Outdated
Comment thread src/components/Select/SuggestionsList/__tests__/SuggestionsList.spec.js Outdated
Comment thread src/components/Select/SuggestionsList/__tests__/SuggestionsList.spec.js Outdated
Comment thread src/components/Select/SuggestionsList/__tests__/SuggestionsList.spec.js Outdated
Comment thread src/components/Select/SelectBase/__tests__/SelectBase.spec.js Outdated
@carlobernardini carlobernardini changed the title feat(Combobox): Add new component feat(ComboboxMulti): Add new component Feb 13, 2020
@igorarkhipenko
igorarkhipenko merged commit 1741223 into master Feb 13, 2020
@igorarkhipenko
igorarkhipenko deleted the 108-combobox branch February 13, 2020 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants