feat(Gauge): add new component - #466
Merged
Merged
Conversation
eszthoff
suggested changes
Mar 17, 2021
eszthoff
suggested changes
Mar 18, 2021
| ) : ( | ||
| <span {...elem('content', props)}> | ||
| {children} | ||
| {metric ? <span {...elem('metric', props)}>{metric}</span> : null} |
Contributor
There was a problem hiding this comment.
If children and metric are ReactNodes, then there is a good chance that wrapping them in span will create incorrect HTML.
| <Gauge | ||
| context={select('Context', CONTEXTS, CONTEXTS[1])} | ||
| percentage={number('Percentage', 33)} | ||
| note={isContentLoading ? '—' : 'Low'} |
Contributor
There was a problem hiding this comment.
It took me sometime to test that it will work with tooltips and other complex things. Maybe you could add one such example
eszthoff
approved these changes
Mar 19, 2021
Contributor
|
@igorarkhipenko It seems like the CircleCI checks did not run on this PR, maybe it was opened before we moved to CircleCI? Maybe you can rebase your branch and force-push. |
igorarkhipenko
force-pushed
the
223-gauge-component
branch
from
March 19, 2021 10:56
dadd73c to
ff3d8a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist