Skip to content

feat(Tag): add new Tag component - #637

Merged
eszthoff merged 10 commits into
masterfrom
tag-component
Nov 12, 2021
Merged

feat(Tag): add new Tag component#637
eszthoff merged 10 commits into
masterfrom
tag-component

Conversation

@konstista

@konstista konstista commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

Story: ONEUI-284

Add new tag component, that could be used in multiple projects.

Checklist

  • The implementation has been manually tested and complies with Textkernel browser support guidelines
  • The implementation complies with accessibility standards.
  • The component has a displayName defined.
  • The component comes with a detailed PropTypes (and defaultProps) definition.
  • Component PropTypes are sufficiently described / documented.
  • There is a story in Storybook.

@konstista konstista changed the title WIP: feat(Tag): add new Tag component feat(Tag): add new Tag component Nov 8, 2021
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.scss Outdated
Comment thread src/components/Tag/__tests__/Tag.spec.js Outdated
Comment thread stories/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.tsx
Comment thread src/components/Tag/Tag.scss
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/components/Tag/Tag.tsx Outdated
Comment thread src/index.ts
Comment thread src/components/Tag/Tag.tsx Outdated
@carlobernardini

carlobernardini commented Nov 10, 2021

Copy link
Copy Markdown
Contributor

@konstantin-lebejko Looks good to me. Just wondering what this is?
Screenshot 2021-11-10 at 09 58 20

@konstista

konstista commented Nov 10, 2021

Copy link
Copy Markdown
Contributor Author

@carlobernardini
Removed unused Tag description.

@carlobernardini
carlobernardini self-requested a review November 10, 2021 12:05
@eszthoff
eszthoff merged commit 5d293b4 into master Nov 12, 2021
@eszthoff
eszthoff deleted the tag-component branch November 12, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants