Skip to content

feat: add title attribute to components - #802

Merged
andrentk merged 1 commit into
masterfrom
add-title-attr-to-components
Aug 11, 2022
Merged

feat: add title attribute to components#802
andrentk merged 1 commit into
masterfrom
add-title-attr-to-components

Conversation

@andrentk

@andrentk andrentk commented Aug 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add title attribute to some OneUI components:

  • Drawer
  • FieldWrapper
  • LocationSelector
  • SelectedOption
  • Teaser

Checklist

  • The implementation has been manually tested and complies with Textkernel browser support guidelines
  • The implementation complies with accessibility standards.
  • The component has a displayName defined.
  • The component comes with a detailed PropTypes (and defaultProps) definition.
  • Component PropTypes are sufficiently described / documented.
  • There is a story in Storybook.

@andrentk
andrentk requested a review from eszthoff August 11, 2022 09:36
@andrentk
andrentk marked this pull request as ready for review August 11, 2022 10:16
@andrentk andrentk changed the title feat: add title attributes to components feat: add title attribute to components Aug 11, 2022
@andrentk
andrentk merged commit 201edea into master Aug 11, 2022
@andrentk
andrentk deleted the add-title-attr-to-components branch August 11, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@mukiienko mukiienko mukiienko approved these changes
@eszthoff eszthoff eszthoff approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrentk @mukiienko @eszthoff