feat(pillDropdown): updated the pill dropdown#1294
Closed
AlsasaAmmar wants to merge 1 commit intomasterfrom
Closed
feat(pillDropdown): updated the pill dropdown#1294AlsasaAmmar wants to merge 1 commit intomasterfrom
AlsasaAmmar wants to merge 1 commit intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrentk
suggested changes
Oct 23, 2024
Contributor
andrentk
left a comment
There was a problem hiding this comment.
The design of the component is still Old UI. Please implement the new UI specs.
I would say that we might want to use the new Dropdown component as base for Pill Dropdown, what do you think? We can discuss in the channel.
Update the PR title to match with the guidelines.
Also this changes already introduces a breaking change, please mark this PR as a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ONEUI-495 Update pill dropdown molecule
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Use imperative, present tense in your commit description ("change", not "changed" or "changes") without uppercases or period (.) at the end.
Checklist