Skip to content

feat(pillDropdown): updated the pill dropdown#1294

Closed
AlsasaAmmar wants to merge 1 commit intomasterfrom
feat/ONEUI-495-update-pill-dropdown
Closed

feat(pillDropdown): updated the pill dropdown#1294
AlsasaAmmar wants to merge 1 commit intomasterfrom
feat/ONEUI-495-update-pill-dropdown

Conversation

@AlsasaAmmar
Copy link
Contributor

ONEUI-495 Update pill dropdown molecule

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Use imperative, present tense in your commit description ("change", not "changed" or "changes") without uppercases or period (.) at the end.

Checklist

  • The implementation has been manually tested and complies with Textkernel browser support guidelines
  • The implementation complies with accessibility standards.
  • The component has a displayName defined.
  • The component comes with a detailed PropTypes (and defaultProps) definition.
  • Component PropTypes are sufficiently described / documented.
  • There is a story in Storybook.

@vercel
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oneui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:02am

Copy link
Contributor

@andrentk andrentk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design of the component is still Old UI. Please implement the new UI specs.
I would say that we might want to use the new Dropdown component as base for Pill Dropdown, what do you think? We can discuss in the channel.

Update the PR title to match with the guidelines.

Also this changes already introduces a breaking change, please mark this PR as a breaking change.

@AlsasaAmmar AlsasaAmmar changed the title updated the pill dropdown feat(pill-dropdown): updated the pill dropdown Oct 23, 2024
@AlsasaAmmar AlsasaAmmar changed the title feat(pill-dropdown): updated the pill dropdown feat(pillDropdown): updated the pill dropdown Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants