Skip to content

Adaption for functions v3 usage #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 30, 2020
Merged

Adaption for functions v3 usage #108

merged 5 commits into from
Mar 30, 2020

Conversation

@BobSilent
Copy link
Collaborator

@BobSilent BobSilent commented Feb 2, 2020 •
edited
Loading

Collection of fixes needed for usage of azure functions v3 and dotnet core 3.1.
this PR is based on (includes) PR #94

added an update.instance command in order to do the migration from v2 to v3 incl. all necessary changes.

New Command update instance
update.instance is a new command which will support the instance update process in an automated way, by doing all necessary changes to install a latest runtime version:

  1. update of the runtime package (if newer Version is found @github) in azure functions. Previously the runtime package was implicitly updated by the update.rulecommand. But this update only updated the runtime binaries, the azure function configuration remains untouched.
  2. With the intended change to use Azure Function V3 Runtime, it was necessary to not only update the binaries but to also change the Runtime Version for Aggregator Azure Function to V3.
  3. Also Compiling rules failed with new version #93, Method not found: get_SerializerSettings #104, Function Returns Response Code 406 #105 made it necessary to change the signature of the run.csx file for each configured rule.
    The update.instance command now supports this migration, it will update the runtime binaries and configure azure functions to use V3, also it will update the exsting configured rules to use the changed run.csx file.

currently work in progress

@prashanthbv12
Copy link

prashanthbv12 commented Feb 3, 2020 via email

@BobSilent
Copy link
Collaborator Author

BobSilent commented Feb 3, 2020

I know, as you see this PR is in draft.
Some updates will follow and description needs to be updated as well.

Also this includes an instance update step and a breaking change, I am not ready that's why this is still work in progress

But it is available for a discussion. I can also provide some details later in PR description

@prashanthbv12
Copy link

prashanthbv12 commented Feb 3, 2020 via email

@BobSilent
Copy link
Collaborator Author

BobSilent commented Feb 4, 2020

you can simply use the previous binaries, as due to the mentioned error the binaries were not able to change anything on server side.

Did you already replace the binaries on Server Side?

@prashanthbv12
Copy link

prashanthbv12 commented Feb 4, 2020 via email

@BobSilent BobSilent mentioned this pull request Feb 23, 2020
Closed
@giuliov giuliov mentioned this pull request Mar 30, 2020
Merged
@giuliov giuliov merged commit 560ac0c into master Mar 30, 2020
@BobSilent BobSilent mentioned this pull request Apr 20, 2020
Closed
@giuliov giuliov deleted the BobSilent/fix-adaption-for-functions-v3 branch July 10, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Function Returns Response Code 406 Method not found: get_SerializerSettings Compiling rules failed with new version

4 participants

@BobSilent @prashanthbv12 @giuliov