Skip to content

Conversation

@BobSilent
Copy link
Collaborator

@BobSilent BobSilent commented Jan 10, 2020

Fixes #91, Fixes #92 and (quick fix) Fixes #99.
For #92 please change back Resource Version to 1.0, as in all other Versions there is a bug that the relations are not send in the the hook event data.

@BobSilent BobSilent force-pushed the fix-identityref-for-resourceversion-1.0 branch from d8c2a4c to 055f624 Compare January 13, 2020 08:54
@BobSilent BobSilent marked this pull request as ready for review January 13, 2020 08:56
@Eckham
Copy link

Eckham commented Jan 13, 2020

The fixes works fine. Thx.

@adu80
Copy link

adu80 commented Jan 14, 2020

The fixes works perfectly, thank you very much @BobSilent

@BobSilent BobSilent force-pushed the fix-identityref-for-resourceversion-1.0 branch from 055f624 to 5c8a0e0 Compare January 14, 2020 09:42
@rotda
Copy link

rotda commented Jan 16, 2020

When will be PR merged ? Than I can build, without that our rules not working anymore

@BobSilent
Copy link
Collaborator Author

give us a little bit of time @giuliov is currently heavily busy, in the meanwhile you could build this PR branch to get the version.

the plan is to release a bugfix version quite soon

@rotda
Copy link

rotda commented Jan 17, 2020

Hi Bob ,

in which folder I must copy the FunctionRuntime.zip that the cli upload the version to azure ?

@BobSilent
Copy link
Collaborator Author

With the install.instance command you can specify a sourceUrl parameter where you can use the path to your zip.
If you add --verbose you see a little more output when updating, only for the case that you need to update version number of your created zip

@rotda
Copy link

rotda commented Jan 21, 2020

@BobSilent I have not updated the Runtime but now I get an error at

var children = parent.Children;

[2020-01-21 09:35:15Z] Initial WorkItem 97077 retrieved from https://dev.azure.com/
[2020-01-21 09:35:17Z] #################Starting########################################
[2020-01-21 09:35:17Z] Loading workitem 43350
[2020-01-21 09:35:17Z] #################1########################################
[2020-01-21 09:35:17Z] #################2########################################
[2020-01-21 09:35:17Z] #################Backlog########################################
[2020-01-21 09:35:17Z] Loading workitems 101333,60909,95799,54329,101287,65658,44467,58865,43351,58580
[2020-01-21 09:35:17Z] Input string was not in a correct format.

@rotda
Copy link

rotda commented Jan 21, 2020

It seems not all the item have this problem , some work some not.
With the old version it was working fine

@BobSilent
Copy link
Collaborator Author

BobSilent commented Jan 21, 2020

unfortunately you are now facing #99, i just added a new commit for it to this pull request.

So you need to pull the changes, rebuild and redeploy.

@rotda
Copy link

rotda commented Jan 21, 2020

Thx now this problem is fixed.
But the functions returns 406 but there is no error

2020-01-21 15:45:09.746 | Changes saved to Azure DevOps (mode Default): 0 created, 3 updated. | Information
-- | -- | --
2020-01-21 15:45:09.746 | 18 | Information
2020-01-21 15:45:09.746 | Returning '18' from 'test3' | Information
2020-01-21 15:45:09.748 | Executed 'Functions.test3' (Succeeded, Id=252219bd-1a49-453a-bdfe-8809c09dbe3c) | Information


@RSMJreck
Copy link

I'm getting a 406 status as well with a very basic rule that just adds to the description.

@BobSilent
Copy link
Collaborator Author

related to #104

@giuliov giuliov merged commit 6747f6e into tfsaggregator:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

6 participants