Fix stray closing paren in syslog tag default in bashlog.sh#462
Merged
Fix stray closing paren in syslog tag default in bashlog.sh#462
Conversation
Fix #451: Remove literal ")" appended to every syslog tag. The default value expression ${0##*/}) had an extra ) outside the parameter expansion braces, causing every syslog message to have a malformed tag like "tfenv-install)" instead of "tfenv-install".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #451
Bug
In
lib/bashlog.shline 30, the syslog tag default had a literal)outside the parameter expansion:This caused every syslog message to have a malformed tag like
tfenv-install)instead oftfenv-install.Testing
./test/run.sh test_list.shpasses (exercises logging subsystem throughout).