Fix unquoted curl options in curlw() to handle paths with spaces#464
Merged
Fix unquoted curl options in curlw() to handle paths with spaces#464
Conversation
Fix #454: Convert TLS_OPT and NETRC_OPT from strings to arrays so they are properly quoted when passed to curl. Paths with spaces in TFENV_NETRC_PATH would previously be word-split. Uses ${arr[@]+"${arr[@]}"} pattern for safe empty-array expansion on bash versions older than 4.4 (notably macOS default bash 3.2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454
Converts
TLS_OPTandNETRC_OPTfrom strings to bash arrays so they are properly quoted when passed to curl. Previously, aTFENV_NETRC_PATHcontaining spaces would be word-split, breaking the curl call.Uses the
${arr[@]+"${arr[@]}"}expansion pattern for safe empty-array handling on bash <4.4 (macOS default bash 3.2 chokes on"${empty_arr[@]}"withset -u).Testing
./test/run.sh test_install_and_use.sh— all tests pass on Linux (exercises curlw for every download).