Fix double-quoted trap in tfenv-install to handle paths safely#465
Merged
Fix double-quoted trap in tfenv-install to handle paths safely#465
Conversation
Fix #455: Replace double-quoted trap string with a cleanup function. The previous "rm -rf ${download_tmp}" trap expanded the variable at definition time without quotes, making it vulnerable to word-splitting if the temp path contained spaces. Using a function reference ensures the variable is expanded at execution time with proper quoting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
Replaces the double-quoted trap string with a cleanup function:
The previous pattern expanded
${download_tmp}at trap definition time without quotes, making it vulnerable to word-splitting if the temp path contained spaces or shell metacharacters. The function approach expands the variable at execution time with proper quoting.Testing
./test/run.sh test_install_and_use.sh— all tests pass on Linux (exercises the install codepath and temp cleanup for every version installed).