Merged
Conversation
- [`_on_external_launch_result`] when receiving an exception, send the traceback to the `latest_traceback` store - improve readability of the `create_action` helper
There already exist `window.close` action by default, so I just set a `<Primary>W` shortcut for it, and for `app.quit`, I set `<Primary>Q` as recommended by GNOME HIG. Other changes: - remove the shortcut for the `win.about` action (it's reserved for the shortcuts window) - [halftone/main] remove unused libraries
Owner
|
Thanks! This should make #96 much easier to implement now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having actions be per window greatly simplifies supporting multiple windows. Which is wanted for #96.
I know some apps have their "About" dialog per application instead, but I don’t see any reason to prevent multiple windows from showing that dialog. I suspect this is an anachronism from the time when these dialogs were proper non-modal windows.