fix: accept MFA tuple in css_overrides config schema#145
Merged
Conversation
The css_overrides schema rejected the {m, f, []} tuple form even
though render_css/1 already branched on it, preventing callers from
generating CSS dynamically per-render.
Closes #140
tfwright
force-pushed
the
fix/css-overrides-mfa-schema
branch
from
94c325b to
3d6dbf8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
:css_overridesschema inLiveAdmin.Applicationvalidatedtype: :string, so the app crashed at boot when a caller supplied the{m, f, []}form — even thoughLiveAdmin.View.render_css/1already pattern-matched on that form.Widens the schema to
{:or, [:string, {:tuple, [:atom, :atom, {:list, :any}]}]}so the schema matches the runtime.Closes #140
Test plan
docker compose run app mix test— 35 tests pass