fix: only flag same-level create/update conflicts#146
Merged
Conversation
PR #144 raised whenever `create_with: false` appeared at any level while a custom `:create` component appeared at any other level, treating cross-level configurations as contradictory. That blocks the pattern #139 describes: disable create globally, then re-enable it per-resource via a custom component. Walk each level independently. A configuration is only contradictory when a single level sets both the disabling option and the custom component; cross-level overrides resolve normally with the more-specific level winning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The validation added in #144 rejected any configuration where
create_with: false(orupdate_with: false) appeared at one config level while a custom:create(or:edit) component appeared at another. That's incompatible with the documented use case from #139: disable create globally, then re-enable it per-resource via a custom component.Change
Walk each config level independently. Only raise when a single level contains both the disabling option and the custom component. Cross-level overrides resolve via normal precedence (resource > scope > app), with the more-specific level winning.
Tests