Add install script#2
Conversation
Co-Authored-By: Trevor Gullstad <tech.gulls@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
trev-gulls
left a comment
trev-gulls
left a comment
There was a problem hiding this comment.
respond to both comments and confirm any changes with the user before making them.
| @@ -0,0 +1,47 @@ | |||
| #!/bin/sh | |||
| # install.sh — install cclog from GitHub Releases | |||
| # Usage: curl -sfL https://raw.githubusercontent.com/tgrnd/cclog/main/install.sh | sh | |||
There was a problem hiding this comment.
Shouldn't this point to the latest version release not the main branch?
There was a problem hiding this comment.
Fixed. The script now resolves the latest release tag via the GitHub API and downloads from /releases/download/{tag}/. The curl URL still points to main for the script itself — standard pattern (Homebrew, golangci-lint do the same). The binary always comes from a tagged release.
There was a problem hiding this comment.
Compare this install script to the one at https://github.com/tgrnd/carbon-copy/blob/main/plugins/cc-event-logs/scripts/install.sh
I want to know if either has gaps or could be improved by learning from the other
There was a problem hiding this comment.
Compared and aligned. Adopted from cc-event-logs: version resolution via GitHub API, OS detection via uname -s | tr. Added from cclog: PATH hint. Both now use env vars (VERSION, INSTALL_DIR) for overrides. The cc-event-logs script could benefit from the PATH hint — worth backporting.
- Resolve latest tag via GitHub API instead of relying on /releases/latest/download redirect - Add VERSION env var override for pinning versions - Align with cc-event-logs install script patterns - Add PATH hint for discoverability Co-Authored-By: Trevor Gullstad <tech.gulls@gmail.com> Co-Authored-By: Claude <noreply@anthropic.com>
2 participants
Summary
install.shfor one-line installs:curl -sfL ... | sh~/.local/binby default, override viaINSTALL_DIRTest plan
shellcheck install.shpasses clean🤖 Generated with Claude Code