mixin: graph compact 'todo' metrics #8062
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filippog
force-pushed
the
compact-dashboard-todo
branch
from
27c4baa to
be95743
Compare
Signed-off-by: Filippo Giunchedi <fgiunchedi@wikimedia.org>
filippog
force-pushed
the
compact-dashboard-todo
branch
from
be95743 to
dfd7164
Compare
Contributor
Author
|
@yeya24 WDYT? |
yeya24
previously approved these changes
Feb 21, 2025
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
This makes sense to me. Thanks a lot!
Signed-off-by: Filippo Giunchedi <filippog@users.noreply.github.com>
Contributor
Author
|
Tests failures are not related, and I've resolved the changelog conflict. Should be good to merge anytime @yeya24, thank you! |
Contributor
Author
|
@yeya24 hello, anything I should be doing on my end to get this merged? thank you ! |
Contributor
Author
|
Can a maintainer please let me know if there is something else on my end on this PR before merging? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add
todometrics to compact dashboardVerification
Verified locally in Grafana