Fix result filenames containing colons that crash on Windows#82
Merged
that-github-user merged 1 commit intomainfrom Mar 28, 2026
Merged
Fix result filenames containing colons that crash on Windows#82that-github-user merged 1 commit intomainfrom
that-github-user merged 1 commit intomainfrom
Conversation
Extract makeResultFilename() to ensure ISO timestamps produce Windows-safe filenames (replace colons and periods with dashes). 3 new tests verify no unsafe characters in generated filenames. Generated by thinktank (5 agents, Agent #5 recommended — tests pass, smallest diff at +28/-1). Closes #59 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Self-review (dogfooding): Generated by thinktank with 5 agents. Agent #5 had cleanest approach — extracted function + tests. No unsafe chars in filename verified by 3 tests. 64 tests pass, lint clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeResultFilename()to produce Windows-safe filenames from ISO timestampsGenerated by thinktank — 5 agents, Agent #5 recommended (tests pass, +28/-1, smallest diff). Agents 1-3 failed tests. Agent 4 passed but larger diff.
Change type
Related issue
Closes #59
How to test
Breaking changes
🤖 Generated with thinktank + Claude Code