refactor: per-protocol result.cc を撲滅し initResult を共通化 (#101)#108
Merged
Conversation
10 プロトコル (cicada, d2pl, ermia, mocc, mvto, oze, si, silo, ss2pl, tictoc) ごとに置かれていた `cc/<proto>/result.cc` (8〜14 行) は、 グローバル変数名 (`SiloResult`, `CicadaResult`, ...) が違うだけの 殻だった。これを `common/result.cc` の単一 `CCBenchResults` ベクター + `initResult(std::size_t)` に集約する。 - 各 protocol の `<Proto>Result` グローバルと parameterless `initResult()` を撤去 - 各ワークロードエントリポイントと `transaction.cc` の参照を `CCBenchResults` に置換 - `cc/<proto>/result.cc` (10 個) を削除 - 各 `CMakeLists.txt` の SOURCES から `result.cc` を除外 - `cc/<proto>/include/result.hh` は root `include/result.hh` への forwarder にして既存の include 行を変えずに済むように - `initResult()` の resize 引数のプロトコル間の揺れ (`FLAGS_thread_num` vs `TotalThreadNum`) は、バッチスレッドを 含めて全プロトコルで `TotalThreadNum` に統一 Release / Debug+ASan 両モードを GCC 13 (CI と同じ) で 10 protocol × 全 workload フルビルド検証済み。 Closes #101
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cc/<proto>/result.cc(8〜14 行のグローバル変数の殻) を撲滅し、common/result.ccの単一CCBenchResults+initResult(std::size_t)に集約resize引数のプロトコル間の揺れ (FLAGS_thread_numvsTotalThreadNum) は、バッチスレッドを含めて全プロトコルでTotalThreadNumに統一cc/<proto>/include/result.hhは rootinclude/result.hhへの forwarder にして、既存の include 行をそのまま使えるようにCloses #101
Test plan