build: shirakami を third_party/shirakami サブモジュールとして追加#114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
third_party/shirakamiに submodule で追加cc/ではなくthird_party/:cc/は ccbench のTxExecutor契約を実装した in-tree プロトコル置き場であり、外部エンジンを置くと意味が混ざるためfb14e65設計メモ
#97/#98で submodule → FetchContent 移行した gtest / masstree / mimalloc / spdlog (passive な build dep) とは位置付けが違う。ピン留めしたい比較ターゲットなので submodule で扱う方針third_party/shirakami/= upstream そのまま」「cc/shirakami/(本 PR では作らない) =TxExecutorを実装する adapter で shirakami の API を呼ぶ」の二層構成を想定。これにより既存のcommon/runner.hhテンプレート ([P2] ワークロードエントリポイント main() を common/runner.hh テンプレートに集約する #102) からシームレスに駆動できるOut of scope (別 PR)
cc/shirakami/の TxExecutor adapter 実装actions/checkoutにsubmodules: recursiveを追加_ja/_enセット)Test plan
git submodule update --init --recursiveで shirakami が clone されること.gitmodulesの path と section name がthird_party/shirakamiで一致していること