style: ソース全体を .clang-format に合わせて一括 reformat#82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
cc/ include/ common/配下の 240 ファイル (.cc/.hh/.cpp) に clang-format 14 を機械適用。意味的変更はゼロ。Closes #74背景: なぜこの PR が必要か
.clang-formatをリポジトリ実態 (2-space 等) に合わせてリファインし、master にマージ済み。refine-clang-formatブランチのままマージされ、master に届いていなかった。.clang-format」+「未整形の 213 ソース」という状態になり、ci: clang-format dry-run チェックジョブを追加 (#63) #78 (CI に clang-format dry-run チェックを追加) の CI が落ちていた。変更規模
clang-format -i(clang-format 14.0.0) の機械適用のみ。手作業の整形・コード変更なし。git ls-files -- cc include common | grep -E '\.(cc|hh|cpp)$'の 240 ファイル。third_party/と build 生成物は対象外。Test plan
clang-format --dry-run --Werrorを全 240 ファイルに適用 → 違反 0。Release+-DENABLE_SANITIZER=OFF+ g++-13) → exit 0、error/warning 0。Phase 5: set_compile_options() で -Wall -Wextra -Werror を有効化 (#43) #80 (Phase 5) で-Wall -Wextra -Werrorが全 target に有効化済みなので、整形後コードがその厳格ゲートを通ることも確認済み。マージ順序
この PR がマージされれば、master のソースが clang-format 14 clean になる。その後 #78 (format.yml の CI チェック追加) を master 取り込み → rebase すれば #78 の CI が緑になる。レビューは機械適用のため diff 個別確認は不要、コマンドの正しさとビルド緑の確認で足りる。