chore(release): staging to production - 2026.05.15#1077
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
## Root Cause Same class of bug as PR #1075 but in `updateChatflow`. The controller calls `getChatflowById(id, req.user.activeWorkspaceId)` before saving. The admin's `activeWorkspaceId` is their Personal Workspace — the template source chatflow lives in the Default Workspace — so the service query returns null and throws "not found in the database", blocking the save. ## Fix One line: admins skip the workspace filter in the lookup, same pattern as the GET controller. ```typescript const isAdmin = req.user?.roles?.includes('Admin') || req.user?.permissions?.includes('org:manage') const chatflow = await chatflowsService.getChatflowById(req.params.id, isAdmin ? undefined : workspaceId) ``` The service still does org-scoped access — it just doesn't add a workspace filter to the SQL query for admins. ## Test Plan - [ ] As an admin, open the default template canvas and save a change — should succeed - [ ] As a non-admin, saving a chatflow in a workspace they don't belong to should still be blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Release: Staging to Production
Release Date: 2026-05-15
Changes in this release
This PR is automatically created/updated when commits are pushed to staging.
Merging this PR will trigger the release workflow to create a new GitHub release.