Skip to content

fix(s3): use AWS SDK default credential chain in standalone scripts and ingest util#1082

Merged
ct3685 merged 1 commit into
stagingfrom
ct/fix-s3-credential-chain-scripts-and-utils
May 20, 2026
Merged

fix(s3): use AWS SDK default credential chain in standalone scripts and ingest util#1082
ct3685 merged 1 commit into
stagingfrom
ct/fix-s3-credential-chain-scripts-and-utils

Conversation

@ct3685
Copy link
Copy Markdown

@ct3685 ct3685 commented May 20, 2026

Problem

Three more files had the same ?? '' S3 credential bug fixed in #1079 — passes empty strings when env vars are absent, breaking IAM/Copilot/ECS deployments.

Files changed

File Issue
packages-answers/scripts/generateCsv.ts Top-level new S3 with ?? '' on both keys
packages-answers/scripts/initCsvRun.ts Top-level new S3 with ?? '' on both keys
packages-answers/utils/src/ingest/document.ts new S3Client with explicit credentials passed unconditionally

Fix

Same pattern as #1079 — only attach credentials when both env vars are non-empty; otherwise omit and let the AWS SDK default credential chain handle it (IAM, ECS task roles, Copilot, Render env vars, etc.).

Test plan

  • Verify CSV standalone scripts work in IAM-based env (no explicit S3 keys)
  • Verify document ingest works in IAM-based env
  • Confirm Render (explicit env vars) still works as before

@vercel
Copy link
Copy Markdown

vercel Bot commented May 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
answerai-docs Building Building Preview May 20, 2026 4:22pm
the-answerai Building Building Preview May 20, 2026 4:22pm

Request Review

@ct3685 ct3685 merged commit c35cf5e into staging May 20, 2026
5 of 7 checks passed
@ct3685 ct3685 deleted the ct/fix-s3-credential-chain-scripts-and-utils branch May 20, 2026 16:23
ct3685 added a commit that referenced this pull request May 20, 2026
## 🚀 Release: Staging to Production

**Release Date:** 2026-05-20

### Changes in this release

- fix(s3): use AWS SDK default credential chain in standalone scripts
and ingest util (#1082) (c35cf5e)

---
*This PR is automatically created/updated when commits are pushed to
staging.*
*Merging this PR will trigger the release workflow to create a new
GitHub release.*

Co-authored-by: Cameron Taylor <50385537+ct3685@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant