Add form for Conditional #2233
Merged
Add form for Conditional #2233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samshara
reviewed
Nov 24, 2021
Comment on lines
+9
to
11
| export type Conjunction = 'XOR' | 'OR' | 'AND'; | ||
|
|
Collaborator
There was a problem hiding this comment.
type defined in ConjuctionInput component
Collaborator
Author
There was a problem hiding this comment.
IMO we can duplicate simple types, better to avoid coupling when possible.
...nditionalEditor/OrganigramConditionalWidgetForm/DescendentOrganigramConditionInput/index.tsx
Outdated
Show resolved
Hide resolved
...s/WidgetConditionalEditor/ScaleConditionalWidgetForm/ComparisonScaleConditionInput/index.tsx
Outdated
Show resolved
Hide resolved
...nents/WidgetConditionalEditor/ScaleConditionalWidgetForm/SimpleScaleConditionInput/index.tsx
Outdated
Show resolved
Hide resolved
...nditionalEditor/SingleSelectConditionalWidgetForm/SimpleSingleSelectConditionInput/index.tsx
Outdated
Show resolved
Hide resolved
...ponents/WidgetConditionalEditor/TextConditionalWidgetForm/SimpleTextConditionInput/index.tsx
Outdated
Show resolved
Hide resolved
...dgetConditionalEditor/TimeRangeConditionalWidgetForm/SimpleTimeRangeConditionInput/index.tsx
Outdated
Show resolved
Hide resolved
tnagorra
force-pushed
the
feature/conditional-form
branch
from
03ac035 to
3d90c9a
Compare
AdityaKhatri
force-pushed
the
develop-new
branch
from
dda5dde to
b626c5b
Compare
- Update interfaces for Conditional - Add Conditional handlers for Text, Number, Date, Time, DateRange, TimeRange - Add conditional add/edit on Primary and Secondary tagging - Add referrer origin on generated html
- Update yarn.lock
tnagorra
force-pushed
the
feature/conditional-form
branch
from
7527a7e to
3bacae8
Compare
AdityaKhatri
force-pushed
the
feature/conditional-form
branch
from
7cfc4a9 to
b0e7eeb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't introduce any:
console.logmeant for debuggingThis PR contains valid: