Options typings for Angular2Apollo service

[Crevil]

To help development, typings on the options arguments in Angular2Apollo service methods could be added.

Angular2Apollo.watchQuery()

Link to source: Angular2Apollo.watchQuery()
Typedef: DeprecatedWatchQueryOptions

Angular2Apollo.query()

Link to source: Angular2Apollo.query()
Typedef: DeprecatedWatchQueryOptions

Angular2Apollo.mutate()

Link to source: Angular2Apollo.mutate()
Typedef: ApolloClient.mutate()

Angular2Apollo.subscribe()

Link to source: Angular2Apollo.subscribe()
Typedef: DeprecatedSubscriptionOptions

[kamilkisiela]

@Crevil Totally agree we need those.

Imagine the situation when the ApolloClient changes those interfaces.

Let's say we support apollo-client in versions ^0.5.0.
Now when there's a change in those interfaces we have to release a new version that supports only ^0.5.2.

I see three ways of doing this:

• release new versions of angular2-apollo on each change
• make apollo-client expose to those those interfaces
• create our own, internal interfaces in angular2-apollo

Which would be the best in your opinion?

[Crevil]

@kamilkisiela
The first option is the most tedious one but keeps things synchronized closely.
The second one would be an easy fix and would work as long as the service is a simple wrapper.
The last one makes things confusing as long as we are only delegating things to apollo-client as they are the same interfaces.

From this I think option two is the better one, for now. If the service get to be more than a wrapper at some point, this could be rethought.

[kamilkisiela]

#145

[kamilkisiela]

#145