Skip to content

Add resizing autohide sidebar#19

Merged
yonaries merged 1 commit intothe-ora:mainfrom
Ffinnis:fix/change-sidebar-width-when-hide
Sep 8, 2025
Merged

Add resizing autohide sidebar#19
yonaries merged 1 commit intothe-ora:mainfrom
Ffinnis:fix/change-sidebar-width-when-hide

Conversation

@Ffinnis
Copy link
Copy Markdown
Contributor

@Ffinnis Ffinnis commented Sep 6, 2025

@kenenisa
Copy link
Copy Markdown
Contributor

kenenisa commented Sep 7, 2025

Can you run swiftformat . please?

Copy link
Copy Markdown
Contributor

@kenenisa kenenisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is some formatting issue that should be handled in pre-commit i don’t think is working please run swiftformat . —quiet and push the changes or let me know if it’s not working.

@Ffinnis
Copy link
Copy Markdown
Contributor Author

Ffinnis commented Sep 7, 2025

swiftformat . —quiet

browser git:(fix/change-sidebar-width-when-hide) swiftformat .
Running SwiftFormat...
Reading config file at /Users/a1/Documents/browser/.swiftformat
SwiftFormat completed in 0.03s.
0/92 files formatted.

@Ffinnis
Copy link
Copy Markdown
Contributor Author

Ffinnis commented Sep 7, 2025

Btw, all changes except browser view was made by precommit

@kenenisa
Copy link
Copy Markdown
Contributor

kenenisa commented Sep 7, 2025

Okay good!

@yonaries
Copy link
Copy Markdown
Contributor

yonaries commented Sep 7, 2025

lgtm. just resolve the conflict.

@Ffinnis Ffinnis force-pushed the fix/change-sidebar-width-when-hide branch from 1d61696 to c84e7b8 Compare September 8, 2025 04:44
@Ffinnis Ffinnis requested a review from kenenisa September 8, 2025 04:48
@yonaries yonaries self-requested a review September 8, 2025 13:39
@kenenisa
Copy link
Copy Markdown
Contributor

kenenisa commented Sep 8, 2025

Somebody raised this issue can you fix it in the pr please. Should be an easy fix

@yonaries yonaries merged commit 06ab6e6 into the-ora:main Sep 8, 2025
1 check passed
kenenisa pushed a commit that referenced this pull request Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants